Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inview ignores locking on resize #612

Open
oliverfoster opened this issue Jan 7, 2025 · 0 comments
Open

inview ignores locking on resize #612

oliverfoster opened this issue Jan 7, 2025 · 0 comments
Assignees
@oliverfoster
Labels
bug Something isn't working

Comments

@oliverfoster
Copy link
Member

Subject of the issue

When fullscreening the video tag in adapt-contrib-media, the browser issues a resize event. inview ignores any inview locking on resize events allowing components to trigger inview completion upon resize.
@oliverfoster oliverfoster added the bug Something isn't working label Jan 7, 2025
@oliverfoster oliverfoster self-assigned this Jan 7, 2025
@oliverfoster oliverfoster moved this from New to Assigned in adapt_framework: The TODO Board Jan 7, 2025
oliverfoster added a commit that referenced this issue Jan 7, 2025
@oliverfoster
Fix: inview respecting locks on window resize (#612)
5145a85
@oliverfoster oliverfoster mentioned this issue Jan 7, 2025
Open
@oliverfoster oliverfoster moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Jan 7, 2025
@oliverfoster oliverfoster mentioned this issue Jan 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverfoster oliverfoster

Labels
bug Something isn't working
Projects
adapt_framework: The TODO Board
Status: Needs Reviewing
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oliverfoster