Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question Completion Order #603

Open
joe-replin opened this issue Nov 7, 2024 · 0 comments
Open

Question Completion Order #603

joe-replin opened this issue Nov 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@joe-replin
Copy link
Contributor

Subject of the issue/enhancement/features

If feedback appears within a pop-up, the question is marked as complete as soon as the feedback pop-up opens. This behavior may conflict with plug-ins that rely on question completion to trigger certain actions. For instance, the Trickle plug-in currently uses the Underscore library to defer updating the button state until the current call stack is clear. Instead, this function could simply rely on element completion instead.

One reason to consider changing this behavior is that feedback pop-ups may contain required content. In such cases, the question should only be marked as complete once the feedback pop-up has been read and closed.

Your environment

  • v5.41.12 FW
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant