Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: properties.schema details update for new setting override #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: properties.schema details update for new setting override #52

wants to merge 1 commit into from

Conversation

cahirodoherty-learningpool
Copy link
Contributor

Fixes #51

Fix

  • Added properties.schema details for AT

@paulstevendev
Copy link

Why are there 2 "Is this optional settings"?

image

@cahirodoherty-learningpool
Copy link
Contributor Author

I'd noticed that too Paul. I am not sure if it's an authoring tool issue or if I've configured something wrongly. I've reached out to Oliver for further info on this

@oliverfoster
Copy link
Member

@taylortom any ideas?

@taylortom
Copy link
Member

It's been a long time since I've looked at the legacy schemas & how their inheritance works but from a cursory glance it looks ok, so not sure why we're getting duplication (AFAIK nothing relevant has been changed in the legacy AT for a long time).

Leave this one with me and will have a proper look when I get a chance.

@cahirodoherty-learningpool
Copy link
Contributor Author

Thanks Tom. Give me a shout if you need any more info or help looking into any aspect

@oliverfoster
Copy link
Member

@taylortom bump

@simondate simondate self-requested a review August 4, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleanor-heath eleanor-heath eleanor-heath approved these changes

@ethan-lp ethan-lp ethan-lp approved these changes

@simondate simondate simondate approved these changes

@oliverfoster oliverfoster Awaiting requested review from oliverfoster

@paul-mediakitchen paul-mediakitchen Awaiting requested review from paul-mediakitchen

Assignees

@taylortom taylortom

Labels
bug
Projects
adapt_framework: The TODO Board
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component schema broken for AT
7 participants
@cahirodoherty-learningpool @paulstevendev @oliverfoster @taylortom @simondate @ethan-lp @eleanor-heath