From a5686fd3bc2401c5a3b9ba2988409bc9df3bde8e Mon Sep 17 00:00:00 2001 From: Paul Gessinger Date: Tue, 10 Dec 2024 14:03:04 +0100 Subject: [PATCH 1/2] chore: Add `google-explicit-constructor` to clang-tidy config --- .clang-tidy | 1 + cmake/ActsStaticAnalysis.cmake | 1 + 2 files changed, 2 insertions(+) diff --git a/.clang-tidy b/.clang-tidy index 98e5bf4bb2f..8fab06eb096 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -4,6 +4,7 @@ Checks: '-*, \ cppcoreguidelines-init-variables, \ cppcoreguidelines-pro-type-member-init, \ google-readability-casting, \ + google-explicit-constructor, \ modernize-concat-nested-namespaces, \ modernize-use-equals-default, \ modernize-use-default-member-init, \ diff --git a/cmake/ActsStaticAnalysis.cmake b/cmake/ActsStaticAnalysis.cmake index 1e563a1846b..e16a45e3747 100644 --- a/cmake/ActsStaticAnalysis.cmake +++ b/cmake/ActsStaticAnalysis.cmake @@ -15,6 +15,7 @@ if(ACTS_RUN_CLANG_TIDY) list(APPEND _chks "cppcoreguidelines-init-variables") list(APPEND _chks "cppcoreguidelines-pro-type-member-init") list(APPEND _chks "google-readability-casting") + list(APPEND _chks "google-explicit-constructor") list(APPEND _chks "modernize-concat-nested-namespaces") list(APPEND _chks "modernize-use-equals-default") list(APPEND _chks "modernize-use-default-member-init") From 883a8643620da2a961b924f5e69a00f7610bcc09 Mon Sep 17 00:00:00 2001 From: Paul Gessinger Date: Tue, 10 Dec 2024 18:06:12 +0100 Subject: [PATCH 2/2] fix limit to 0 --- CI/clang_tidy/limits.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/CI/clang_tidy/limits.yml b/CI/clang_tidy/limits.yml index 9c5e59cb2af..88625ea9779 100644 --- a/CI/clang_tidy/limits.yml +++ b/CI/clang_tidy/limits.yml @@ -4,6 +4,7 @@ limits: "cppcoreguidelines-init-variables": 0 "cppcoreguidelines-pro-type-member-init": 0 "google-readability-casting": 0 + "google-explicit-constructor": 0 "modernize-concat-nested-namespaces": 0 "modernize-use-equals-default": 0 "modernize-use-default-member-init": 0