Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: fetchFunc MUST always be memoized #8

Open
activenode opened this issue Jan 25, 2024 · 0 comments
Open

Improvement: fetchFunc MUST always be memoized #8

activenode opened this issue Jan 25, 2024 · 0 comments

Comments

@activenode
Copy link
Owner

The refresh function refreshes when the fetchFunc does. But in fact, it doesn't make sense per clean coding principle to change the fetch function at any point as all dependencies can be passed and will be passed to the function.

So essentially, right now the downside is: by just passing a function, the refresh function is never memoized as it always refreshes.

Rethink this behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant