Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required states can come from native elements [4e8ab6] #2138

Open
WilcoFiers opened this issue Nov 14, 2023 · 1 comment · May be fixed by #2154
Open

Required states can come from native elements [4e8ab6] #2138

WilcoFiers opened this issue Nov 14, 2023 · 1 comment · May be fixed by #2154
Assignees

Comments

@WilcoFiers
Copy link
Member

This came from a comment from @JAWS-test on a review

The following shouldn't fail the Element with role attribute has required states and properties rule. The checked state is present even without the aria-checked attribute, because it is on a native checkbox.

<input type="checkbox" role="menuitemcheckbox">
@carlosapaduarte carlosapaduarte changed the title Requires states can come from native elements [4e8ab6] Required states can come from native elements [4e8ab6] Dec 5, 2023
@Jym77
Copy link
Collaborator

Jym77 commented Dec 7, 2023

Decision:

  • we need "implicitly set" and "explicitly set" definitions.
  • "required state" rule should accept implicitly set states (i.e., this example is good, there is no author error)
  • "allowed states" rule should only flagged explicitly set states (i.e. <input type="checkbox" role="button"> shouldn't be flagged for un-allowed aria-checked since it is not an author error).

@Jym77 Jym77 removed the Agenda item label Dec 7, 2023
@Jym77 Jym77 linked a pull request Jan 11, 2024 that will close this issue
7 tasks
@Jym77 Jym77 self-assigned this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants