Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LivyClient not honouring verify=False passed to requests_session #107

Open
ashokkumarrathore opened this issue Aug 4, 2023 · 0 comments

Comments

@ashokkumarrathore
Copy link

ashokkumarrathore commented Aug 4, 2023

When custom requests.Session is passed to LivySession.create(), it does not honour 'Verify'.
Code sample:

        r_session = requests.Session()
        r_session.verify=False

        livy_session = LivySession.create(
            LIVY_URL,
            requests_session=r_session,
            kind=SessionKind.SQL)

This ignores verify=False set in requests session and will go ahead with default(Verify=true) behaviour.

We can either update it from arg requests_Session from here :

self.verify = verify

or pass appropriate value here :

verify=self.verify,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant