Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 1.7.7 no persistent term stored with this key #1325

Closed
phanmn opened this issue Jul 12, 2024 · 12 comments
Closed

[Bug] 1.7.7 no persistent term stored with this key #1325

phanmn opened this issue Jul 12, 2024 · 12 comments

Comments

@phanmn
Copy link

phanmn commented Jul 12, 2024

If submitting a bug, please provide the following:

Environment

  • Elixir version (elixir -v): Elixir 1.16.1 (compiled with Erlang/OTP 26)
  • Absinthe version (mix deps | grep absinthe): locked at 1.7.7 (absinthe) 21455198
  • Client Framework and version (Relay, Apollo, etc):

Expected behavior

No error

Actual behavior

no persistent term stored with this key

Relevant Schema/Middleware Code

Work on 1.7.6, very simple schema

@benwilson512
Copy link
Contributor

Hi @phanmn can you confirm that you have the supervision child in your supervision tree?

@phanmn
Copy link
Author

phanmn commented Jul 12, 2024

I comfirm I have the supervision child in my supervision tree. As I said I changed to 1.7.6 it works normally

@luhagel
Copy link

luhagel commented Jul 14, 2024

This happens to me since the update as well, only with the PersistentTerm provider enabled though.
Turning that off leads to another problem though, in the form of a warning: redefining module MyAppWeb.Schema.Compiled which causes all queries to fail unless i delete the beam file in question before every server start

@benwilson512
Copy link
Contributor

If either of you could provide a small sample project that exhibits this behavior that would be very helpful.

@luhagel
Copy link

luhagel commented Jul 15, 2024

@benwilson512 Trying to cobble one together when i get a bit of time 👍

@luhagel
Copy link

luhagel commented Jul 15, 2024

@benwilson512 There you go: https://github.com/luhagel/absinthe_persistent_term
No magic in there, create a new project with the newest phx.new, add absinthe, create a minimalistic schema, add the routing config and it goes boom once you try to run anything against it.

defmodule AbsinthePersistentTermWeb.Schema do
  use Absinthe.Schema
  @schema_provider Absinthe.Schema.PersistentTerm

  query do
    field :hello, :string do
      resolve(& &1)
    end
  end
end

@benwilson512
Copy link
Contributor

Hey @luhagel thanks, looking into it.

@benwilson512
Copy link
Contributor

Fixed by #1326.

@benwilson512
Copy link
Contributor

I'll release 1.7.8 here shortly if you can confirm this resolves the issue in your app too.

@VictorGaiva
Copy link

This also fixed an issue I was having when attempting to update to 1.7.7. My CI would call mix absinthe.schema.sdl --schema Gateway.Schema, that would fail due to not finding the definition for some fields.

@luhagel
Copy link

luhagel commented Jul 16, 2024

@benwilson512 fixed it for me 👍

@benwilson512
Copy link
Contributor

1.7.8 has been pushed with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants