From 5fbf4facd166a54caea27f0dcfbf1ea8a2b1d395 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?St=C3=A9phane=20Francel?= <stephane.francel@zenika.com>
Date: Tue, 17 Dec 2024 00:09:19 +0100
Subject: [PATCH] client: improve manager page titles (#732)

---
 client/e2e/requested-feedback.spec.ts                        | 2 +-
 client/src/app/app.routes.ts                                 | 1 -
 .../manager/manager-document/manager-document.component.html | 2 +-
 .../src/app/manager/manager-list/manager-list.component.html | 2 +-
 client/src/app/manager/manager.routes.ts                     | 2 ++
 client/src/locales/messages.en.json                          | 5 +++--
 client/src/locales/messages.fr.json                          | 3 ++-
 7 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/client/e2e/requested-feedback.spec.ts b/client/e2e/requested-feedback.spec.ts
index 557f9ebb9..a09cfb7bc 100644
--- a/client/e2e/requested-feedback.spec.ts
+++ b/client/e2e/requested-feedback.spec.ts
@@ -108,7 +108,7 @@ test('Requested feedback', async ({ page }) => {
   await managerPage.matchDoneFeedback(Persona.Bernard, Persona.Alfred, feedbackDetails);
 
   // Go back to the list of shared feedbacks
-  await page.getByRole('button', { name: 'FeedZbacks partagés' }).click();
+  await page.getByRole('button', { name: 'Liste des feedZbacks partagés' }).click();
   await page.waitForURL('/fr/manager/list/**');
 
   // View the feedback expected from Charles
diff --git a/client/src/app/app.routes.ts b/client/src/app/app.routes.ts
index dfcc8e887..a044afb38 100644
--- a/client/src/app/app.routes.ts
+++ b/client/src/app/app.routes.ts
@@ -61,7 +61,6 @@ export const routes: Routes = [
     path: 'manager',
     loadChildren: () => import('./manager/manager.routes'),
     canActivate: [authGuard, managerGuard],
-    title: 'FeedZback - ' + $localize`:@@Action.Manager: Manager `,
   },
   {
     path: 'sign-in',
diff --git a/client/src/app/manager/manager-document/manager-document.component.html b/client/src/app/manager/manager-document/manager-document.component.html
index 2e51c29c1..730667072 100644
--- a/client/src/app/manager/manager-document/manager-document.component.html
+++ b/client/src/app/manager/manager-document/manager-document.component.html
@@ -1,6 +1,6 @@
 <button class="gbl-link gbl-link--back" [routerLink]="['../../list', document().receiverEmail]">
   <mat-icon>arrow_back</mat-icon>
-  <ng-container i18n="@@Title.SharedFeedZbacks">FeedZbacks partagés</ng-container>
+  <ng-container i18n="@@Title.SharedFeedbackList">Liste des feedZbacks partagés</ng-container>
 </button>
 
 <h1 class="gbl-page-title">
diff --git a/client/src/app/manager/manager-list/manager-list.component.html b/client/src/app/manager/manager-list/manager-list.component.html
index 66df9e713..05cba2484 100644
--- a/client/src/app/manager/manager-list/manager-list.component.html
+++ b/client/src/app/manager/manager-list/manager-list.component.html
@@ -1,7 +1,7 @@
 <h1 class="gbl-page-title">
   <!-- TODO: remove the "overflow-visible" CSS once the "hub" Material icon is fixed (it is currently cropped)-->
   <mat-icon class="!overflow-visible">hub</mat-icon>
-  <ng-container i18n="@@Title.SharedFeedZbacks">FeedZbacks partagés</ng-container>
+  <ng-container i18n="@@Title.SharedFeedbackList">Liste des feedZbacks partagés</ng-container>
 </h1>
 
 <mat-form-field appearance="outline" class="w-full">
diff --git a/client/src/app/manager/manager.routes.ts b/client/src/app/manager/manager.routes.ts
index b690608f3..dd620a80f 100644
--- a/client/src/app/manager/manager.routes.ts
+++ b/client/src/app/manager/manager.routes.ts
@@ -13,11 +13,13 @@ export const managerRoutes: Routes = [
     path: 'list/:managedEmail',
     loadComponent: () => import('./manager-list/manager-list.component'),
     resolve: { list: managerListResolver },
+    title: 'FeedZback - ' + $localize`:@@Title.SharedFeedbackList:Liste des feedZbacks partagés`,
   },
   {
     path: 'document/:feedbackId',
     loadComponent: () => import('./manager-document/manager-document.component'),
     resolve: { document: managerDocumentResolver },
+    title: 'FeedZback - ' + $localize`:@@Title.SharedFeedbackDetails:Détails du FeedZback partagé`,
   },
 ];
 
diff --git a/client/src/locales/messages.en.json b/client/src/locales/messages.en.json
index 8c60fc55d..b6a4872f9 100644
--- a/client/src/locales/messages.en.json
+++ b/client/src/locales/messages.en.json
@@ -160,7 +160,7 @@
     "Title.AppTagline": "Request and give feedback to your colleagues",
     "Title.Confirmation": "Confirmation",
     "Title.Drafts": "Draft",
-    "Title.FeedbackDetails": "Feedback details",
+    "Title.FeedbackDetails": "FeedZback details",
     "Title.FeedbackGiven": "FeedZback given",
     "Title.FeedbackToGive": "FeedZback to give",
     "Title.GiveFeedback": "Give spontaneous feedZback",
@@ -172,7 +172,8 @@
     "Title.RequestedFeedback": "FeedZback requested",
     "Title.RequestedFeedbackList": "Reply to feedZback requests",
     "Title.Settings": "Settings",
-    "Title.SharedFeedZbacks": "Shared feedZbacks",
+    "Title.SharedFeedbackDetails": "Shared feedZback details",
+    "Title.SharedFeedbackList": "Shared feedZback list",
     "Title.SignIn": "Sign in",
     "Word.Later": "Later",
     "Word.Or": "or"
diff --git a/client/src/locales/messages.fr.json b/client/src/locales/messages.fr.json
index 03e83d967..f060a5721 100644
--- a/client/src/locales/messages.fr.json
+++ b/client/src/locales/messages.fr.json
@@ -172,7 +172,8 @@
     "Title.RequestedFeedback": "FeedZback demandé",
     "Title.RequestedFeedbackList": " Répondre aux demandes de feedZback ",
     "Title.Settings": "Paramètres",
-    "Title.SharedFeedZbacks": "FeedZbacks partagés",
+    "Title.SharedFeedbackDetails": "Détails du FeedZback partagé",
+    "Title.SharedFeedbackList": "Liste des feedZbacks partagés",
     "Title.SignIn": "Se connecter",
     "Word.Later": "Plus tard",
     "Word.Or": "ou"