Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow DOM content is not shown in the Just Read view #445

Open
Peartato opened this issue Jan 13, 2025 · 1 comment
Open

Shadow DOM content is not shown in the Just Read view #445

Peartato opened this issue Jan 13, 2025 · 1 comment
Labels

Comments

@Peartato
Copy link

When attempting to view this article on ScreenRant with Just-Read, it is treated as if it were a blank page. And despite showing the author and date published on the original page, the Just-Read version shows Unknown Author/Date

Steps to reproduce the behavior:

  1. Go to 'https://www.msn.com/en-us/movies/reviews/the-hobbit-20-differences-between-the-book-the-movies/ar-AA1e1agt'
  2. Click on 'Continue Reading' to bring up full text
  3. Activate Just-Read

Expected behavior
Full article in readable format

Screenshots
Before and after activating Just-Read:
just read

Please complete the following information:

  • OS: Windows 10 Pro
  • Chrome
  • Version 131.0.6778.265 (Official Build) (64-bit)
@ZachSaucier
Copy link
Owner

Hey Peartato. Thanks a lot for the report!

That website's markup is very interesting as it uses the shadow DOM for its content instead of the "light DOM" (i.e. regular HTML). There's already an open issue for this within the Readability repository, which Just Read uses for auto-selection.

Just Read will also be needed to be updated to select this content in the user-selection mode... I'll see about doing that when I get some time.

Thanks again for the report! Sorry for Just Read not working on this version of the MSN website -- the web is always changing so tools have to be updated to accommodate like this.

@ZachSaucier ZachSaucier changed the title Article shows no text at all, even omitting the author and date published Shadow DOM content is not shown in the Just Read view Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants