-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It should say Good Morning #409
Comments
then what do you suggest to show between 12 and 3 am |
Good Night? 😅 |
Its easy to fix i guess, i mean just a line changes right? |
What do you want here to be shown when the time is around 12 to 3 am |
Good Night..of course |
"Good night" is typically used as a farewell just before going to bed, rather than as a general greeting. Greetings in the home page are there as welcome the user (not as a farewell), that why we haven't included it. |
@itz-rj-here @prem-k-r lmk if I should add this too in the current pr |
My knowledge says no for now. 🥸 |
I know, but then whats the logic of saying Good Morning at night |
Its alright |
logically if you say it's morning after 12 am.. Gregorian calendar.. morning != sunrise well I think morning is more appropriate than night |
Bruh just leave it. We will see that thing later what can we do. |
Atleast make it good evening instead? |
@prem-k-r what you think about it? It is a good idea actually. |
Hi @ceskyDJ, your thought on this? |
persnally, i like this |
Upper one is custom UserText.. user can write whatever they want |
ik, I thought we were fixing it to smth since only the upper text changed in the 2 photos |
Hi guys! I've known about this weird greetings for some time. It's definitely not good currently. I'm for @itz-rj-here's suggestion, but I don't like the two line string for night time. The text itself is pretty good, but it doesn't look good with the line break inside. I'm just thinking about the time ranges. I think it's pretty individual based on country/culture and individuals, too. I'd prefer to set, when it's (from my point of view, so the new tab should respect it):
But defaults definitely could be set as @itz-rj-here presented above. |
I like this |
It does |
The text was updated successfully, but these errors were encountered: