Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It should say Good Morning #409

Open
Anasarfeen123 opened this issue Dec 29, 2024 · 24 comments
Open

It should say Good Morning #409

Anasarfeen123 opened this issue Dec 29, 2024 · 24 comments
Labels
invalid This doesn't seem right under discussion This request/suggestion is still under discussion

Comments

@Anasarfeen123
Copy link

image

@itz-rj-here itz-rj-here added the bug Something isn't working label Dec 29, 2024
@prem-k-r
Copy link
Collaborator

then what do you suggest to show between 12 and 3 am

@itz-rj-here
Copy link
Collaborator

then what do you suggest to show between 12 and 3 am

Good Night? 😅

@Anasarfeen123
Copy link
Author

Its easy to fix i guess, i mean just a line changes right?

@itz-rj-here
Copy link
Collaborator

Its easy to fix i guess, i mean just a line changes right?

What do you want here to be shown when the time is around 12 to 3 am

@itz-rj-here itz-rj-here added the question Further information is requested label Dec 29, 2024
@Anasarfeen123
Copy link
Author

Its easy to fix i guess, i mean just a line changes right?

What do you want here to be shown when the time is around 12 to 3 am

Good Night..of course

@prem-k-r
Copy link
Collaborator

"Good night" is typically used as a farewell just before going to bed, rather than as a general greeting.

Greetings in the home page are there as welcome the user (not as a farewell), that why we haven't included it.

@Thunder-Blaze
Copy link
Contributor

@itz-rj-here @prem-k-r lmk if I should add this too in the current pr

@itz-rj-here
Copy link
Collaborator

@itz-rj-here @prem-k-r lmk if I should add this too in the current pr

My knowledge says no for now. 🥸

@itz-rj-here itz-rj-here added invalid This doesn't seem right and removed bug Something isn't working question Further information is requested labels Dec 29, 2024
@Anasarfeen123
Copy link
Author

"Good night" is typically used as a farewell just before going to bed, rather than as a general greeting.

Greetings in the home page are there as welcome the user (not as a farewell), that why we haven't included it.

I know, but then whats the logic of saying Good Morning at night

@Anasarfeen123
Copy link
Author

@itz-rj-here @prem-k-r lmk if I should add this too in the current pr

My knowledge says no for now. 🥸

Its alright

@prem-k-r
Copy link
Collaborator

prem-k-r commented Dec 29, 2024

"Good night" is typically used as a farewell just before going to bed, rather than as a general greeting.
Greetings in the home page are there as welcome the user (not as a farewell), that why we haven't included it.

I know, but then whats the logic of saying Good Morning at night

logically if you say it's morning after 12 am.. Gregorian calendar.. morning != sunrise
but yeah common sense.. its not morning :p

well I think morning is more appropriate than night

@itz-rj-here
Copy link
Collaborator

"Good night" is typically used as a farewell just before going to bed, rather than as a general greeting.
Greetings in the home page are there as welcome the user (not as a farewell), that why we haven't included it.

I know, but then whats the logic of saying Good Morning at night

logically if you say it's morning after 12 am.. Gregorian calendar.. morning != sunrise but yeah common sense.. its not morning :p

well I think morning is more appropriate than night

Bruh just leave it. We will see that thing later what can we do.
Me logging off too.

@Anasarfeen123
Copy link
Author

Bruh just leave it. We will see that thing later what can we do. Me logging off too.

Atleast make it good evening instead?

@Anasarfeen123 Anasarfeen123 changed the title It should say Good Morning after 3 am It should say Good Morning Dec 29, 2024
@itz-rj-here itz-rj-here added the work in progress The issue is on progress to fix label Dec 30, 2024
@itz-rj-here
Copy link
Collaborator

@prem-k-r what you think about it? It is a good idea actually.
image

@prem-k-r
Copy link
Collaborator

two lines
image

but maybe ok
image

@prem-k-r
Copy link
Collaborator

Hi @ceskyDJ, your thought on this?

@itz-rj-here
Copy link
Collaborator

two lines image

but maybe ok image

image
Reply from GPT.

@Anasarfeen123
Copy link
Author

@prem-k-r what you think about it? It is a good idea actually. image

persnally, i like this

@Thunder-Blaze
Copy link
Contributor

two lines image

but maybe ok image

are we changing the upper one too ?
welcome back seems best to me for the upper one
for the lower one imo we can go with rj's last post image

@prem-k-r
Copy link
Collaborator

Upper one is custom UserText.. user can write whatever they want

@Thunder-Blaze
Copy link
Contributor

Upper one is custom UserText.. user can write whatever they want

ik, I thought we were fixing it to smth since only the upper text changed in the 2 photos

@ceskyDJ
Copy link
Contributor

ceskyDJ commented Dec 30, 2024

Hi @ceskyDJ, your thought on this?

Hi guys! I've known about this weird greetings for some time. It's definitely not good currently. I'm for @itz-rj-here's suggestion, but I don't like the two line string for night time. The text itself is pretty good, but it doesn't look good with the line break inside.

I'm just thinking about the time ranges. I think it's pretty individual based on country/culture and individuals, too. I'd prefer to set, when it's (from my point of view, so the new tab should respect it):

  • morning,
  • afternoon,
  • night.

But defaults definitely could be set as @itz-rj-here presented above.

@Anasarfeen123
Copy link
Author

Hi @ceskyDJ, your thought on this?

Hi guys! I've known about this weird greetings for some time. It's definitely not good currently. I'm for @itz-rj-here's suggestion, but I don't like the two line string for night time. The text itself is pretty good, but it doesn't look good with the line break inside.

I'm just thinking about the time ranges. I think it's pretty individual based on country/culture and individuals, too. I'd prefer to set, when it's (from my point of view, so the new tab should respect it):

  • morning,
  • afternoon,
  • night.

But defaults definitely could be set as @itz-rj-here presented above.

I like this

@theoneand33
Copy link

It does

@itz-rj-here itz-rj-here removed the work in progress The issue is on progress to fix label Jan 24, 2025
@prem-k-r prem-k-r added the under discussion This request/suggestion is still under discussion label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right under discussion This request/suggestion is still under discussion
Projects
None yet
Development

No branches or pull requests

6 participants