Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Typo error and UI Enhancement for Search Bar Dropdowns #359

Open
ashesbloom opened this issue Dec 22, 2024 · 11 comments
Open

Bug: Typo error and UI Enhancement for Search Bar Dropdowns #359

ashesbloom opened this issue Dec 22, 2024 · 11 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ashesbloom
Copy link

Description

On the homepage, below the search bar, the left-side element currently displays the text "Search with", which should be corrected to "Search on".

Steps to Reproduce

  1. Navigate to https://xengshi.github.io/materialYouNewTab/.
  2. Observe the text displayed below the search bar on the left-hand side.

Screenshots

image

Additional Context

To improve user clarity and functionality, consider separating "Search on" and "Search with" into distinct categories, potentially implemented as dropdown menus:

  • Search on: Allow users to select platforms such as YouTube, ChatGPT, LinkedIn, etc.
  • Search with: Enable users to choose browser engines like Chrome, Bing, DuckDuckGo, Brave, etc.
@ashesbloom ashesbloom changed the title BUG: Typo error in 'search with' it should be 'search on' Bug: Incorrect Text and UI Enhancement for Search Bar Dropdowns Dec 22, 2024
@ashesbloom ashesbloom changed the title Bug: Incorrect Text and UI Enhancement for Search Bar Dropdowns Bug: Typo error and UI Enhancement for Search Bar Dropdowns Dec 22, 2024
@XengShi
Copy link
Owner

XengShi commented Dec 22, 2024

Search on: Allow users to select platforms such as YouTube, ChatGPT, LinkedIn, etc.
Nice idea 💡

@itz-rj-here itz-rj-here added enhancement New feature or request good first issue Good for newcomers labels Dec 29, 2024
@TitanX311
Copy link

hello @XengShi @ashesbloom i want to work on the issue. But has it already been resolved?

@itz-rj-here
Copy link
Collaborator

hello @XengShi @ashesbloom i want to work on the issue. But has it already been resolved?

@prem-k-r

@prem-k-r
Copy link
Collaborator

prem-k-r commented Jan 9, 2025

Hi @TitanX311, it's hasn't been resolved.
Before proceeding can you please share what's your plan? how it will looks like

@ashesbloom
Copy link
Author

@itz-rj-here yeah go ahead, though I have created a patch but it's buggy and needs polish!

@TitanX311
Copy link

TitanX311 commented Jan 9, 2025

Hi @TitanX311, it's hasn't been resolved. Before proceeding can you please share what's your plan? how it will looks like

as mentioned the idea about a dropdown menu with a sliding animation(similar to the "AI Tools" option) and having options like "search with" and "search on". the "search with" option will have google, brave, yahoo etc. and "search on" will have options like spotify, youtube, youtube music etc. Also thought of changing the icon of twitter.
image

Also for your kind info, i am a complete beginner in open source and want to seek guidance.
thank you

@prem-k-r
Copy link
Collaborator

prem-k-r commented Jan 9, 2025

Also thought of changing the icon of twitter.

Well, we have intentionally not updated the icon to 𝕏

@prem-k-r
Copy link
Collaborator

prem-k-r commented Jan 9, 2025

as mentioned the idea about a dropdown menu with a sliding animation(similar to the "AI Tools" option) and having options like "search with" and "search on". the "search with" option will have google, brave, yahoo etc. and "search on" will have options like spotify, youtube, youtube music etc. Also thought of changing the icon of twitter. image

Also for your kind info, i am a complete beginner in open source and want to seek guidance. thank you

@XengShi

@ashesbloom
Copy link
Author

ashesbloom commented Jan 9, 2025

@prem-k-r @TitanX311 I was thinking more like this but with some transition animations or something that goes with the theme.

Untitled.video.-.Made.with.Clipchamp.1.mp4

PS: if anyone needs this patch ping me up, I'll provide you

@prem-k-r
Copy link
Collaborator

prem-k-r commented Jan 9, 2025

It's nice, I was also thinking of clickable Search with, instead of dropdown.

Maybe you can open a PR on draft, people can do the changes there

@TitanX311
Copy link

@prem-k-r @TitanX311 I was thinking more like this but with some transition animations or something that goes with the theme.

Untitled.video.-.Made.with.Clipchamp.1.mp4
PS: if anyone needs this patch ping me up, I'll provide you

please provide the patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants