Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Config Tests #1872

Open
PeterChen13579 opened this issue Feb 3, 2025 · 1 comment
Open

Refactor Config Tests #1872

PeterChen13579 opened this issue Feb 3, 2025 · 1 comment
Labels
refactoring Code improvements without logical changes
Milestone
2.4

Comments

@PeterChen13579
Copy link
Collaborator

Motivation

Currently Config tests data (FakeConfigData.hpp) is big and used across multiple tests. It is better to split the data into smaller configs, and to test things separately. (ie value & array)

Solution

Refactor Config Tests
@PeterChen13579 PeterChen13579 added the refactoring Code improvements without logical changes label Feb 3, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Clio Feb 3, 2025
@PeterChen13579 PeterChen13579 added this to the 2.4 milestone Feb 4, 2025
@kuznetsss
Copy link
Collaborator

A few more things to fix:

  • ConfigValueTests.cpp contains tests for constraints
  • ClioConfigDefinitionTests.cpp should be renamed to ConfigDefinitionTests.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Code improvements without logical changes
Projects
Clio
Status: 📋 Backlog
Milestone
2.4
Development

No branches or pull requests
2 participants
@kuznetsss @PeterChen13579