Skip to content

Latest commit

 

History

History
42 lines (23 loc) · 1.84 KB

pull_request_template.md

File metadata and controls

42 lines (23 loc) · 1.84 KB

Summary

[<TITLE>](<long or short link to the trello card that is being developed>)

Github Issue: #<number of issue that is being solved>

A brief description of the pull request.

Known issues / Notes

If you found any issues while developing the feature, this is the place where you should detail everything. Also you can report bugs found or any missing functionality.

Screenshots or Screencasts

If your code modifies front end views, then you should attach screenshots for every modification. You should add a screenshot of the original design and your implementation, for various devices or browsers.

If you need to record a video (or gif) to show a change in flow or animations:

  • you can use LICECap for OSX
  • you can check this for Ubuntu to add animated gifs to your pull request to show some transitions between views
  • you can use QuickTime to record from device (if you need to test on device because of bluetooth use for example). Check this tutorial on how to record a screencast with Quicktime and then check this tutorial on how to convert the .mov to .gif file in order to be able to attach it to the pull request.

Test Plan

You should add here any necessary information for being able to run the new code (any migrations needed or scripts to run).

Then you should add at least one test plan:

  • Open the app
  • Login with username '[email protected]' password '123456'
  • You should see a tost with spinner while logging in.
  • The main tab bar view should appear after a successfull login.

Others ...

You could add any other section you may need, like Discussion for example.