Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Node.js v23 #1281

Closed
mceachen opened this issue Oct 20, 2024 · 3 comments · Fixed by #1283
Closed

Add support for Node.js v23 #1281

mceachen opened this issue Oct 20, 2024 · 3 comments · Fixed by #1283

Comments

@mceachen
Copy link
Member

mceachen commented Oct 20, 2024

v23.0.0 got released a couple of days ago. @neoxpert (or anyone else), if you add that to the build matrix in a PR, I can merge it:

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 6e47139..4fd5801 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -15,9 +15,9 @@ on:
 env:
   # See https://github.com/nodejs/release#release-schedule
   # Node.js v16 EOL = 2023-09-11. v21 EOL = 2024-06-01.
-  NODE_BUILD_CMD: npx --no-install prebuild -r node -t 18.0.0 -t 20.0.0 -t 22.0.0 --include-regex 'better_sqlite3.node$'
+  NODE_BUILD_CMD: npx --no-install prebuild -r node -t 18.0.0 -t 20.0.0 -t 22.0.0 -t 23.0.0 --include-regex 'better_sqlite3.node$'
   # Merge with NODE_BUILD_CMD when Node.js v18 is EOL
-  NO_V18_NODE_BUILD_CMD: npx --no-install prebuild -r node -t 20.0.0 -t 22.0.0 --include-regex 'better_sqlite3.node$'
+  NO_V18_NODE_BUILD_CMD: npx --no-install prebuild -r node -t 20.0.0 -t 22.0.0 -t 23.0.0 --include-regex 'better_sqlite3.node$'
   # See https://www.electronjs.org/docs/latest/tutorial/electron-timelines#version-support-policy
   # Electron v25 EOL = 2023-12-05. v26 EOL = 2024-02-20. v27 EOL = 2024-04-16. v28 EOL = 2024-06-11. v29 EOL = 2024-08-20.
   ELECTRON_BUILD_CMD: npx --no-install prebuild -r electron -t 26.0.0 -t 27.0.0 -t 28.0.0 -t 29.0.0 -t 30.0.0 -t 31.0.0 -t 32.0.0 -t 33.0.0 --include-regex 'better_sqlite3.node$'
@@ -35,6 +35,7 @@ jobs:
           - 18
           - 20
           - 22
+          - 23
     name: Testing Node ${{ matrix.node }} on ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
     steps:
mceachen added a commit to mceachen/better-sqlite3 that referenced this issue Oct 20, 2024
@mceachen
Copy link
Member Author

PR #1282 proves that everything works under Node.js v23 🎉 (but someone else needs to submit the diff for me to approve it)

@neoxpert
Copy link
Contributor

Just created a pull request.

@mceachen
Copy link
Member Author

Thanks @neoxpert ! YOU ROCK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants