Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Dispel Item Curse fails to dispel non-vanilla curse enchantments #227

Closed
1 task done
KnightCa opened this issue Jan 5, 2024 · 1 comment
Closed
1 task done
Labels
bug Something isn't working

Comments

@KnightCa
Copy link

KnightCa commented Jan 5, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Observed behaviour

While the spell dispels item vanilla curses from worn armor or off-hand items, it doesn't effect non-vanilla curses.

Vanilla (working):
Curse of Binding
Curse of Vanishing

So Many Enchantments:
Bluntness
Curse of Decay
Curse of Holding
Curse of Inaccuracy
Curse of Possession
Curse of Vulnerability
Cursed Edge
Heavy Weight
Inefficient
Instability
Powerless
Rusted
Unpredictable

Charm:
Curse of Rusting
Curse of Clumsiness
Curse of Haunting
Curse of Harming

Expected behaviour

I expected the spell to remove cursed enchantments from non-vanilla sources.

Steps to reproduce

  1. Join a Server
  2. Try to castle Dispel Item Curse on a off-hand item enchanted with one of the non-vanilla curses.
  3. Notice the lack of effect

Crashlog

No response

Environment (Singleplayer/Server, etc.)

Issue present on both sides

Mod version

1.5.11-PreRelease-4f214c5

Forge version

1.12.2-forge-14.23.5.2860

Other mods

No response

@KnightCa KnightCa added the bug Something isn't working label Jan 5, 2024
@KnightCa KnightCa changed the title [Bug] Dispel Item Curse [Bug] Dispel Item Curse fails to dispel non-vanilla curse enchantments Jan 5, 2024
@WinDanesz
Copy link
Owner

I'm not familiar with the registry names of these mods' enchantments, but I reworked the spell to allow adding them to a configuration list.
If you feel like, you can help by getting a list of them so that I can add them to the default list.


		@Config.Name("Curses that the Dispel Item Curse spell can remove. Should work with modded enchantments as well.")
		@Config.RequiresMcRestart
		public String[] dispel_item_curse_list = {
				"minecraft:vanishing_curse",
				"minecraft:binding_curse"
		};

WinDanesz added a commit that referenced this issue Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants