Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Battlemage Runewords may be accessible by non-battlemage NPC Wizards #225

Closed
1 task done
KnightCa opened this issue Jan 5, 2024 · 0 comments
Closed
1 task done
Labels
bug Something isn't working

Comments

@KnightCa
Copy link

KnightCa commented Jan 5, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Observed behaviour

Can non-Battlemage NPCs be assigned Battlemage runewords by the mob generator that have the spell json listed NPC as True (example Runeword: Endure)?

I havent yet seen them cast, just noticed them set to be castable by NPC Wizards on the assets/spells config section.

This would either cause a issue in the non-Battlemage caster being assigned a spell they can't cast or be a issue thematically in them casting Runeword spells without Battlemage armor.

ie "If I want battlemages to use the runewords and keep it enabled for npcs in the json, I'll have to also override a method in those spells' java class file to only allow them for battlemage NPCs."

Expected behaviour

While NPC Battlemages should be able to get access to certain Runewords, non-Battlemage NPC's should not be assigned Runewords.

Steps to reproduce

There isn't a current way to assign Runewords to NPC casters (Battlemage or Wizard) to test this with, so it would need to be checked in the code.

Crashlog

No response

Environment (Singleplayer/Server, etc.)

Not sure

Mod version

1.5.11-PreRelease-54bfadc

Forge version

1.12.2-forge-14.23.5.2860

Other mods

No response

@KnightCa KnightCa added the bug Something isn't working label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant