Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up JS/HTML-wrapped core test export for WPT #1860

Open
dschuff opened this issue Dec 20, 2024 · 1 comment
Open

Clean up JS/HTML-wrapped core test export for WPT #1860

dschuff opened this issue Dec 20, 2024 · 1 comment

Comments

@dschuff
Copy link
Member

dschuff commented Dec 20, 2024

We've recently added automatic import of Wasm tests into the Web Platform Tests repo by using the HTML-wrapper output of the test/build.py script (see web-platform-tests/wpt#49277).

There are several cleanups and improvements planned:

  1. Currently the testharness* files checked into the test harness directory are an out-of-date copy of the ones from upstream WPT, and are manually ignored by the import process. We should either delete them from the spec repo, or adjust test/build.py to not include them in the export.

  2. Currently we are using the existing HTML wrappers, but since wasm is available in workers and doesn't actually require HTML, we should probably switch to exporting the tests as any.js instead. We are already using these for the JS and Web API tests.

  3. As part of these, several things in that script could be cleaned up.
    Based on the conversation in build.py doesn't build tests in subdirectories #1687 it seems that neither Mozilla nor Google are using the existing JS or HTML export capabilities (and I would be interested in hearing from @kmiller68 or @ddegazio whether/how WebKit is using them). If none of the JS engine vendors are using this script for importing core tests into their own workflows, then we can simplify test/build.py to only support the use case of exporting tests to WPT (and possibly for some sort of convenient standalone testing of those exports? Not sure if that would be useful or not).

  4. Longer term we want to set up automatic export of tests from in-progress proposals too (marking them as "tentative"). I was imagining this would go via the testsuite repo, but it will be complicated by the fact that we also need updated spec interpreter or some other way to convert those tests to binary; so maybe we would need to go directly from proposal repos. Anyway, some way to get tests onto WPT before they go to phase 5 and get finally merged into the spec would be good.

@dschuff
Copy link
Member Author

dschuff commented Dec 20, 2024

/cc @past @ajklein

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant