Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert backend to typescript #115

Open
amirrr opened this issue Jan 23, 2024 · 4 comments
Open

Convert backend to typescript #115

amirrr opened this issue Jan 23, 2024 · 4 comments
Assignees

Comments

@amirrr
Copy link
Collaborator

amirrr commented Jan 23, 2024

There needs to be multiple steps:

Migrate to the newer sequelize-typescript for typescript database models.
Convert every file to typescript and continue in typescript (checkJs: false)
Go through every file and fix typing issues (checkJs: true)

@markwhiting
Copy link
Member

What's the status on this effort? I think we perhaps decided we couldn't do some things because of some fundamental problems, but I forget how we finalized that discussion. Any updates @amirrr

@amirrr
Copy link
Collaborator Author

amirrr commented Jul 1, 2024

sequilize typescript is still work in progress https://sequelize.org/docs/v6/other-topics/typescript/ and there are some small configurations needed to move to typescript. But there are ways around that and we can do that. I am working on the typescript branch on figuring out the sequilize part but once that's done, we can slowly convert to typescript. I say let's keep this open but mostly focus on getting it to run with typescript complier and then make the change once stable.

@markwhiting
Copy link
Member

This is mostly done, right?

@amirrr
Copy link
Collaborator Author

amirrr commented Oct 8, 2024

Not yet. It is more like 10% done. This can be considered technical debt we have to address at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants