Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoding issue after scanning QR code with external wallet #5506

Open
work-kevin-flynn opened this issue Nov 19, 2024 · 1 comment
Open

Decoding issue after scanning QR code with external wallet #5506

work-kevin-flynn opened this issue Nov 19, 2024 · 1 comment
Labels
type: bug Something isn't working

Comments

@work-kevin-flynn
Copy link

work-kevin-flynn commented Nov 19, 2024

Describe the bug
This is an extension from WalletConnect/modal-react-native#112 with more logs pertaining to @walletconnect/core and upon further investigation, it seems to be a decoding issue from undefined where a string was expected

SDK Version (if relevant)

"@walletconnect/core" "2.11.0"
"@walletconnect/universal-provider" "2.11.0"

To Reproduce
Steps to reproduce the behavior:

  • Open wallet connect modal
  • Choose QR code
  • Scan QR with one of the external wallet app (MetaMask/Trust/Bitget/Binance etc)
  • Confirm in external wallet

Expected behavior
Expectation - after confirmation from external wallet, walletconnect modal should proceed
Actual - the modal hangs and does nothing

Screenshots
image
where the exception happens after scanning QR code with external wallet

Log
added console.log('-0-0-0', string, alphabet, bitsPerChar, buffer) to /node_modules/multiformats/cjs/src/bases/base.js

  // -0-0-0 undefined ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/= 6 -1618315363

Smartphone (please complete the following information):

  • Device: iPhone 15 (simulator)
  • OS: iOS 17.2
  • Browser: N/A
  • Version [e.g. 22]

Additional context

@work-kevin-flynn work-kevin-flynn added the type: bug Something isn't working label Nov 19, 2024
Copy link

linear bot commented Nov 19, 2024

@work-kevin-flynn work-kevin-flynn changed the title Decoding issue after scanning QR code with external wallet Invalid payload which breaks flow after scanning QR code with external wallet Nov 19, 2024
@work-kevin-flynn work-kevin-flynn changed the title Invalid payload which breaks flow after scanning QR code with external wallet Exception after scanning QR with external wallet Nov 19, 2024
@work-kevin-flynn work-kevin-flynn changed the title Exception after scanning QR with external wallet Decoding issue after scanning QR code with external wallet Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant