Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Wakamai Fondue codebase wishlist #183

Open
RoelN opened this issue Oct 7, 2024 · 2 comments
Open

My Wakamai Fondue codebase wishlist #183

RoelN opened this issue Oct 7, 2024 · 2 comments

Comments

@RoelN
Copy link
Contributor

RoelN commented Oct 7, 2024

My Wakamai Fondue codebase wishlist:

  • Update to newest Node (Related: Drop old Node support? wakamai-fondue-engine#42)
  • Vue 2 → Vue 3 (Looks like we were at Vue 3 already, but used some Vue 2 methods that need to be updated)
  • Update all dependencies
  • Vue setup review: is this thing being built efficiently?
  • Vue setup review: am I doing everything as Vue-y as possible, or am I shoehorning React-y or vanilla JS into the pages?
  • Are there any convoluted/outdated workarounds that can be removed or updated?

Maybe not everything is needed from a technical standpoint. Perhaps it's more a piece of mind matter!

I don't mind doing the Vue stuff, that's in my comfort zone.

Part of why this is in my head, is that I believe we had to do some hacking to work with older Node and ESM modules?

Ideally I (and everyone else) can clone the repo and have Wakamai Fondue running in a minute without having to duckduckgo a vague error once!

@Ryuno-Ki
Copy link
Contributor

Ryuno-Ki commented Oct 7, 2024

My thoughts on this:

  • Build against a matrix in CI to learn early on of problematic combinations
  • Vue 3 might bring you in the very same spot in the future again. Check carefully whether it is worth the investment. (As in: what are your requirements that made you pick Vue in the first place? Are they still valid? Are other tech stacks like HTMX or Web Components options?)
  • Give dependabot some love to keep them updated
  • Define efficient (some of your dependencies moved to esbuild. Given you're using Vue, Vite might be worth a look as well)
  • What is your motivation to be Vue-y? (I want to understand the context better.)
  • Pretty sure. Shall I take a closer look? :)

@RoelN
Copy link
Contributor Author

RoelN commented Oct 7, 2024

@Ryuno-Ki I chose Vue back for Wakamai Fondue v1.0 just to experiment with it, but like it often goes, the prototype morphed into a version that actually got released. I like it, and my interest to work with other technologies is certainly there, but to focus the limited time folks like you and me have I don't mind continuing with Vue.

If a version 3 update doesn't bring anything interesting, then I'm fine with sticking with 2. I don't have problems with how Vue works, it does the job and gets out of the way so I can focus on the fonty stuff.

Hey André, I appreciate your help! I'll think about the other questions & post tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants