Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate test Project.toml into main Project.toml #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pjaap
Copy link
Member

@pjaap pjaap commented Feb 3, 2025

Let's see if it runs through

@pjaap
Copy link
Member Author

pjaap commented Feb 5, 2025

@chmerdon Seems fine now. I think the module is more maintainable if we have only a single Project.toml.
Adding new test dependencies can now easily be done in the [extras] section plus in the [targets] list.

@j-fu
Copy link
Member

j-fu commented Feb 6, 2025

... It is a matter of taste IMHO. I didn't find a reference stating what is preferred by the julia developers.

I personally kind of prefer to have test/Project.toml . Anyway we also have docs/Project.toml.

@pjaap
Copy link
Member Author

pjaap commented Feb 6, 2025

When I was new to Julia I was always confused by the splitting into test/main Project.toml. I think @chmerdon has to decide here :)

docs is different. For me, docs is an independent project on top of the actual module.

@chmerdon
Copy link
Member

chmerdon commented Feb 6, 2025

is docs really that independent? it runs the same examples, uses all the docstrings... I also find it weird to have then still the docs/Project.toml separately. Can one handle the docs similarly with another target docs?

@pjaap
Copy link
Member Author

pjaap commented Feb 6, 2025

Technically, docs is a project/environment on its own. You explicitly activate docs in order to create the docs.
Testing, on the other hand, is done out of the main project.

As far as I know, the only valid [targets] are test and build (see Julia Doc).

And I think 2 Project.toml files are still better than 3 separate files :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants