[Bug]: phone endpoint should support dtmfAnswer and onAnswer

[nakaakist]

Node Version

20.x

Platform

Mac (Apple Silcon)

SDK Version

"@vonage/voice": "1.16.1"

Code Sample

client.transferCallWithNCCO(uuid, [
  {
    action: NCCOActions.CONNECT,
    from: 'xxx',
    endpoint: [
      {
        type: 'phone',
        dtmfAnswer: '1234',
        onAnswer: {
          url: 'https://example.com/answer',
          ringbackTone: 'http://example.com/ringbackTone.wav',
        },
      },
    ],
  },
]);

client.createOutboundCall({
  to: [
    {
      type: 'phone',
      number: 'xxx',
      dtmfAnswer: '1234',
    },
  ],
  from: {
    type: 'phone',
    number: 'yyy',
  },
  answerUrl: ['https://example.com'],
});

Expected Behavior

The two examples provided include dtmfAnswer and onAnswer (onAnswer is only in NCCO) and should pass type checks. This is because these properties are documented in the official references: NCCO Reference and Voice API Reference

Actual Behavior

dtmfAnswer and onAnswer are not included in the type definitions, resulting in type errors.

[manchuck]

@nakaakist I will add onAnswer to the NCCO type and let the team know about the API spec. Since there is a discrepancy, I want to verify with the Voice team the correct properties.

[manchuck]

@nakaakist I opened #979, which addresses the missing types. When I added answer to NCCO, I did not get any type errors. Can you provide me with the error from Typescript so I can track it?

[nakaakist]

@manchuck Following is the type error.

Object literal may only specify known properties, and 'onAnswer' does not exist in type 'PhoneEndpoint'.

175                 onAnswer: {
                    ~~~~~~~~

[manchuck]

Thank you for that. I figured out why the test did not fail. Thanks for the help with that. Once the PR is approved I will cut a release

[manchuck]

This has been released with 3.19.4 of the server-sdk (or if you are using the standalone)1.17.1 of @vonage/voice