Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable request timeouts #478

Merged
merged 6 commits into from
Sep 7, 2023
Merged

feat: configurable request timeouts #478

merged 6 commits into from
Sep 7, 2023

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented Sep 6, 2023

Addresses the long-requested #136 🙂. Should also fix #470 and #471.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Merging #478 (6c623e1) into main (2e07f7d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #478   +/-   ##
=========================================
  Coverage     93.51%   93.52%           
- Complexity     2842     2844    +2     
=========================================
  Files           436      436           
  Lines          7217     7227   +10     
  Branches        440      441    +1     
=========================================
+ Hits           6749     6759   +10     
  Misses          275      275           
  Partials        193      193           
Files Changed Coverage Δ
src/main/java/com/vonage/client/VonageClient.java 98.87% <ø> (ø)
src/main/java/com/vonage/client/HttpConfig.java 76.59% <100.00%> (+3.42%) ⬆️
src/main/java/com/vonage/client/HttpWrapper.java 100.00% <100.00%> (ø)

@SMadani SMadani changed the title Configurable request timeouts feat: configurable request timeouts Sep 7, 2023
@SMadani SMadani marked this pull request as ready for review September 7, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build.yml - Ensure top-level permissions are not set to write-all
3 participants