Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] 词云 insertZerosToArray 方法在部分环境下性能存在问题 #619

Open
xiaoluoHe opened this issue Jan 10, 2025 · 0 comments
Open

[Feature] 词云 insertZerosToArray 方法在部分环境下性能存在问题 #619

xiaoluoHe opened this issue Jan 10, 2025 · 0 comments
Assignees
@Rui-Sun

Comments

@xiaoluoHe
Copy link
Contributor

xiaoluoHe commented Jan 10, 2025 •
edited
Loading

What problem does this feature solve?

在部分电脑上还是可以复现，目前也没找到具体是哪里影响了，但可以明确的是主要影响“[].splice”性能，把insertZerosToArray的实现去掉splice依赖后，可以基本解决（2.6s > 590ms）

What does the proposed API look like?

添加配置，支持自定义 insertZerosToArray 实现
No response
Rui-Sun added a commit that referenced this issue Jan 13, 2025
@Rui-Sun
feat: add customInsertZerosToArray in wordcloud #619
47dca88
xile611 added a commit that referenced this issue Jan 15, 2025
@xile611
Merge pull request #620 from VisActor/feat/customInsertZerosToArray
97b36a5 
feat: add customInsertZerosToArray in wordcloud #619
@github-actions github-actions bot mentioned this issue Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rui-Sun Rui-Sun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xiaoluoHe @Rui-Sun