From ec2e3075196019615e8ec3b11f49796e3831c49b Mon Sep 17 00:00:00 2001 From: xiaoluoHe Date: Tue, 26 Mar 2024 15:07:19 +0800 Subject: [PATCH] fix: show map name without nameMap --- packages/vchart/src/series/map/map.ts | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/vchart/src/series/map/map.ts b/packages/vchart/src/series/map/map.ts index a35b79ec66..2c67c50949 100644 --- a/packages/vchart/src/series/map/map.ts +++ b/packages/vchart/src/series/map/map.ts @@ -299,10 +299,15 @@ export class MapSeries extends GeoSer } const name = datum.properties?.[this._nameProperty]; if (name) { - if (this._spec.nameMap && this._spec.nameMap[name]) { - return this._spec.nameMap[name]; + if (this._spec.nameMap) { + if (this._spec.nameMap[name]) { + return this._spec.nameMap[name]; + } } - if (this._spec.showDefaultName) { + // TODO: + // 1. showDefaultName 是一个考虑配置兼容的产物,不然会有 break-change + // 2. 后续大版本升级,这里无需判断条件,直接返回 name 是更合理的 + if (this._spec.showDefaultName || !this._spec.nameMap) { return name; } }