Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Pull lacks timeout functionality, causing plugin hang when SSH agent is not running #840

Open
davidkopp opened this issue Jan 17, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@davidkopp
Copy link

Describe the bug

The plugin appears to lack a timeout mechanism for the pull functionality. When the plugin is configured to pull at startup or on a schedule, it hangs indefinitely if the SSH agent is not running (or locked). This renders the plugin unusable until the SSH agent is started and the plugin is restarted.

Relevant errors (if available) from notifications or console (CTRL+SHIFT+I)

obsidian-git: Pulling....
obsidian-git: Retry watch for ask pass

Steps to reproduce

  • Configure the git repository with SSH
  • Configure the plugin to perform a pull operation at startup.
  • Ensure the SSH agent is not running.
  • Restart the plugin
  • Try to execute any plugin command

Expected Behavior

The pull command should have a timeout configured. If the timeout is reached, the operation should fail gracefully without hanging the plugin, allowing other plugin commands to function.

Addition context

I'm using KeePassXC as a SSH agent

Operating system

Windows

Installation Method

None

Plugin version

2.31.1

@davidkopp davidkopp added the bug Something isn't working label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant