From d64cebaf143b4cb251fa392fd540870286d61f7a Mon Sep 17 00:00:00 2001 From: Luis Presuel Date: Mon, 23 Sep 2024 12:21:30 -0600 Subject: [PATCH] fix proxy config override and removes comments --- pkg/playbook/app/vcertutil/vcertutil.go | 10 +++++----- pkg/venafi/cloud/connector.go | 2 -- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/pkg/playbook/app/vcertutil/vcertutil.go b/pkg/playbook/app/vcertutil/vcertutil.go index a6fc2cde..8c9a5baf 100644 --- a/pkg/playbook/app/vcertutil/vcertutil.go +++ b/pkg/playbook/app/vcertutil/vcertutil.go @@ -122,12 +122,12 @@ func buildClient(config domain.Config, zone string, timeout int) (endpoint.Conne if !connectionTrustBundle.AppendCertsFromPEM([]byte(vcertConfig.ConnectionTrust)) { return nil, fmt.Errorf("%w: failed to parse PEM trust bundle", verror.UserDataError) } - vcertConfig.Client.Transport = &http.Transport{ - TLSClientConfig: &tls.Config{ - RootCAs: connectionTrustBundle, - MinVersion: tls.VersionTLS12, - }, + netTransport.TLSClientConfig = &tls.Config{ + RootCAs: connectionTrustBundle, + MinVersion: tls.VersionTLS12, } + + vcertConfig.Client.Transport = netTransport } // build Authentication object diff --git a/pkg/venafi/cloud/connector.go b/pkg/venafi/cloud/connector.go index 2f2116aa..e877bc76 100644 --- a/pkg/venafi/cloud/connector.go +++ b/pkg/venafi/cloud/connector.go @@ -1267,8 +1267,6 @@ type managedCertificate struct { } func (c *Connector) getCertificate(certificateId string) (*managedCertificate, error) { - // Flow renew certificate - //var err error url := c.getURL(urlResourceCertificateByID) url = fmt.Sprintf(url, certificateId)