Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

${HDF5_C_LIBRARY_hdf5} still used in cxx4/CMakeLists.txt #107

Open
lakinwecker opened this issue Apr 25, 2021 · 1 comment
Open

${HDF5_C_LIBRARY_hdf5} still used in cxx4/CMakeLists.txt #107

lakinwecker opened this issue Apr 25, 2021 · 1 comment

Comments

@lakinwecker
Copy link

SET(ALL_TLL_LIBS ${HDF5_C_LIBRARY_hdf5})
as referenced in a few issues (notably #92 and #106), this variable seems to be empty and should probably be replaced with: ${HDF5_C_LIBRARIES}

@lakinwecker
Copy link
Author

lakinwecker commented Apr 25, 2021

This is certainly not the correct fix ( lakinwecker@327bc0b ) but I was trying to compile netcdf-cxx4 master against the conan-centre provided hdf5, and netcdf. I have netcdf-cxx4 as a submodule in my project, and I have it added to the project via add_subdirectory and these are the changes necessary to get it to compile/link properly. I doubt these are the correct changes, but something to consider.

At the moment, I feel that the netcdf and hdf5 packages provided by conan-centre are not properly providing the variables and so find_package is having to do some default things, and thus I can't depend on a specific variable to nicely capture all of the sub dependencies of both for linking purposes.

I realize that this may not quite be the appropriate forum for this information, but I'm also not sure where else to put it. Hopefully this isn't too much noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant