Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Refactor send/recv API #55

Open
hogura99 opened this issue Jan 2, 2025 · 1 comment
Open

[Enhancement] Refactor send/recv API #55

hogura99 opened this issue Jan 2, 2025 · 1 comment

Comments

@hogura99
Copy link
Collaborator

hogura99 commented Jan 2, 2025

Currently, we send/recv the tensors directly through tensor.data_ptr(), which is unsafe if we want to perform async send/recv (especially for sampler&tokenizer). Maybe try to replace all the raw pointers with the tensors.
@hogura99
Copy link
Collaborator Author

hogura99 commented Jan 6, 2025

#58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hogura99