Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Everything to Work in CMSSW 104X #6

Open
3 of 4 tasks
JHiltbrand opened this issue Jan 23, 2019 · 1 comment
Open
3 of 4 tasks

Get Everything to Work in CMSSW 104X #6

JHiltbrand opened this issue Jan 23, 2019 · 1 comment
Assignees

Comments

@JHiltbrand
Copy link

JHiltbrand commented Jan 23, 2019

Currently, working in with specific release CMSSW_10_4_0_patch1. The working branch is tweaksFor104X

TODO LIST

  • Jet resolution text file on L169 of cmsWRextension.cc is hard coded to a 2016 file. This needs to be flexible for all three years of Run II.

  • Choosing globaltag and JSON file in job submission script should figure out which tags / JSON to use based on the year being run over.

  • Jet correction uncertainty values text file needs to not be hard coded for 2016.

  • Figure out muon efficiencies/SFs and PU weights for all three years.

@JHiltbrand
Copy link
Author

JHiltbrand commented Jan 23, 2019

Minor changes to allow compilation:

In TunePMuonProducer.cc:

  • std::auto_ptr needed to be changed to a std::unique_ptr with event.put(mus) becoming event.put(std::move(mus)). NOTE: std::unique_ptr is compatible with CMSSW_8_1_X and up.

In cmsWRextension.h:

  • #include "FWCore/Framework/interface/EDAnalyzer.h"

@JHiltbrand JHiltbrand self-assigned this Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant