Log viewer HTTP API does not support .eval format

[tadamcz]

It tries to parse the binary as JSON and raises:

Error: JSON5: invalid character 'P' at 1:1

The necessary changes are somewhere in api-http.mjs. (Note that I'm about to modify that file with #1184, so it would be best to make this change downstream from that.)

[dragonstyle]

It does support eval files (we use them quite a bit) so there is likely something specific in your scenario that isn't being handled properly by the viewer. Can you say more about how to reproduce this?

[tadamcz]

Sorry to be unclear. By the HTTP API of the viewer, I mean the stuff defined in api-http.mjs and index.mjs

I'm passing in a URL to an .eval file in the log_file URL query parameter:

inspect_ai/src/inspect_ai/_view/www/src/api/index.mjs

Line 36 in 302893f

const log_file = urlParams.get("log_file");

[dragonstyle]

I'm familiar with that code.

So you're just forming a url with a log file pointing to an eval file- I'll give that a try later today and report back.

[tadamcz]

It's calling asyncJsonParse

inspect_ai/src/inspect_ai/_view/www/src/utils/Json.mjs

Lines 3 to 30 in 302893f

	export const asyncJsonParse = async (text) => {
	const encoder = new TextEncoder();
	const encodedText = encoder.encode(text);
	const blob = new Blob([kWorkerCode], { type: "application/javascript" });
	const blobURL = URL.createObjectURL(blob);
	const worker = new Worker(blobURL);
	try {
	const result = new Promise((resolve, reject) => {
	worker.onmessage = function (e) {
	if (e.data.success) {
	resolve(e.data.result);
	} else {
	reject(new Error(e.data.error));
	}
	};
	worker.onerror = function (error) {
	reject(new Error(error.message));
	};
	});
	worker.postMessage({ scriptContent: kJson5ScriptBase64, encodedText }, [
	encodedText.buffer,
	]);
	return await result;
	} finally {
	worker.terminate();
	URL.revokeObjectURL(blobURL);
	}
	};

and throwing on

inspect_ai/src/inspect_ai/_view/www/src/utils/Json.mjs

Line 15 in 302893f

reject(new Error(e.data.error));

because the contents are not JSON.

[tadamcz]

The fix might be as simple as using openRemoteLogFile

inspect_ai/src/inspect_ai/_view/www/src/log/remoteLogFile.mjs

Line 33 in 302893f

export const openRemoteLogFile = async (api, url, concurrency) => {

I'm happy to take a crack at it if you'd like. If you could review #1184 first that would be helpful, so that I don't have to deal with potential merge conflicts.

[dragonstyle]

Yeah I think the question is why it is improperly treating the file as a json file rather than and eval file.

[tadamcz]

Ah, so it's supposed to already detect .eval files when passed in? Can you show me where that happens?

[dragonstyle]

Reasoning about the log file based upon the type happens one layer up in the client-api. I've opened a PR which moves the file handling for this case up to that level (see referenced PR).