B9 Validation #254
B9 Validation #254
Conversation
|
@Oddvocado Nice catch on the correct RequiredIf for COURSE and FRSTCHG. I'm also noticing that COURSE has a wrong value for Not Applicable. Can you change the value of "Not applicable" to 8 in the
|
|
@ashleybot good catch! I went ahead and changed the radio button value from 6 to 8. Ready for another review! |
|
Adding issue #255 to this PR as well |
|
@ashleybot Took care of issue #255 with this commit -->1cf5619
I take that back. Still need to address some additional validation |
|
@ashleybot B9 could use additional enabling/disabling in the UI. For examples 12l should only be enabled when any question 12h-12k has a value of 1. This pattern shows up a couple additional times in the form. As of now PSYCHAGE only has model validation. Since these cards are high priority I was thinking we can create a new card for the UI? Let me know your thoughts!
As of now this PR is ready for another review. Should fix issues #252 #255 & #256 |
There was a problem hiding this comment.
@Oddvocado Looks good! Good to bump to 4.6.15. I added a couple of commits:
- [New item] I noticed PERCHAGE wasn't following the correct rules for validation - fixed
- TIL adding a value tag will cause some odd behaviors with rendering. So, I removed the value attribute on the new PSYCHAGE input field and it renders properly.
Screenshot of incorrect rendering (the PSYCHAGE value was rendered to the hidden field rather than the number input, so it appeared as though it didn't save)
Fixed by removing value attribute
@Oddvocado Thanks for your attention to detail on this form. Let's go through it as a group on Monday and add some cards to the backlog together.
Fixes #252
Fixes #255
Fixes #256
Corrected the properties "MOMODE,"MOMOPARK" and "MOMOALS" to be required if "DECCLMOT" has a value of 1. "COURSE" and "FRSTCHG" have also been updated to be required one "DECCLIN" has a value of 1 per documentation here --> https://github.com/naccdata/uniform-data-set/blob/main/forms/uds/b9/form_b9_ivp_error_checks_mc.csv