Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error log message for duplicate or missing collection id is not very helpful #24

Open
graykr opened this issue Jan 8, 2025 · 0 comments
Assignees
Labels
collection record issues related to the collection record error log enhancement issue related to idea to enhance the error log

Comments

@graykr
Copy link

graykr commented Jan 8, 2025

The log messages are not very helpful.

For example:
Empty collection ID. Changed to ##4ld

aspaceCopyUtil.addErrorMessage("Empty collection ID. Changed to " + id + "\n");
https://github.com/archivesspace/archon-migration/blob/5ab5bc4aed3607a71923ec91e0a515680c361f7b/src/org/nyu/edu/dlts/utils/ASpaceMapper.java#L950

The error would be easier to debug if this included the Archon id:
aspaceCopyUtil.addErrorMessage("Empty collection ID for collection with Archon ID " + dbId + ". Changed to " + id + "\n");

Similarly, for duplicate IDs (hopefully will not be an issue if we add the prefix, but just in case):
message = "Duplicate Resource Id: " + id + " Changed to: " + fullId + "\n";
https://github.com/archivesspace/archon-migration/blob/5ab5bc4aed3607a71923ec91e0a515680c361f7b/src/org/nyu/edu/dlts/utils/ASpaceMapper.java#L1699

Adding in the Archon ID:
message = "Duplicate Resource Id: " + id +"(Archon ID " + dbId + ") Changed to: " + fullId + "\n";

@graykr graykr added collection record issues related to the collection record error log enhancement issue related to idea to enhance the error log labels Jan 8, 2025
@graykr graykr self-assigned this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
collection record issues related to the collection record error log enhancement issue related to idea to enhance the error log
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant