Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creator names in archon in lastname, firstname order are incorrectly coded as "direct" order in ASpace #21

Open
graykr opened this issue Jan 8, 2025 · 0 comments
Labels
creator record issues related to the creator record (called agent record in aspace)

Comments

@graykr
Copy link

graykr commented Jan 8, 2025

Based on the tooltips in ASpace, I believe a name written as lastName, firstName should be coded as "indirect" name order. However, the migration code is listing it as "direct". It's not clear whether this affects anything at this point, so I would leave it alone for now (but am noting it as an issue so we remember it in case there are related side effects noted later).

namesJS.put("name_order", "direct");
https://github.com/archivesspace/archon-migration/blob/5ab5bc4aed3607a71923ec91e0a515680c361f7b/src/org/nyu/edu/dlts/utils/ASpaceMapper.java#L435

If we try to fix it, we'd have to check whether the creator is a person (and has a comma in their name -- sometimes we don't know a first and last name for a person) or a corporate entity first.

@graykr graykr added the creator record issues related to the creator record (called agent record in aspace) label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
creator record issues related to the creator record (called agent record in aspace)
Projects
None yet
Development

No branches or pull requests

1 participant