Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused pipes and variables from the codebase #75

Open
markmatney opened this issue Nov 30, 2017 · 1 comment
Open

Remove unused pipes and variables from the codebase #75

markmatney opened this issue Nov 30, 2017 · 1 comment
Assignees

Comments

@markmatney
Copy link
Contributor

In reviewing the documentation, I noticed some variables (src/data/books.ts) and pipes (ParseJsonPipe, DerpPipe, ImplodePipe) that do not seem to be used anywhere in the code. Please review and remove these files if they are unused.

Also, in general, please remove any other unused code that you can find, including commented-out lines that no longer serve a purpose, e.g.

// let oldcode = true ? 'this is unnecessary' : 'test';
@Hlopec
Copy link
Contributor

Hlopec commented Dec 6, 2017

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants