-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a "local" storage driver that handles all operations in memory #112
Open
lonelycode
wants to merge
15
commits into
main
Choose a base branch
from
in-mem-kv
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonelycode
changed the title
Adds a "local" storage driver that handles all oeprations in memory
Adds a "local" storage driver that handles all operations in memory
Aug 12, 2024
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
This was referenced Aug 12, 2024
I have read the CLA Document and I hereby sign the CLA |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a "local" storage handler type, this uses an in-memory non-blocking hashmap to store data, the implementation is entirely in Go, and the local handler
API
object is designed to take any KV store as a back-end but will perform all advanced operations (such as sets and sorted sets) in go instead of using native capabilities. This is so we can experiment with multiple k/v stores without having to write a whole new interface implementation from scratch (e.g. some k/v stores may not have delete or flush capabilities).Related Issue
https://tyktech.atlassian.net/browse/TT-748
Motivation and Context
Having a "stateless" version of Tyk makes testing easier for end users and our team. It also means that new users can"kick the tyres" quickly without needing to set up Redis and therefore get time-to-value down.
Test Coverage For This Change
Changes were tested with the existing
testutil
package, extended for all temporal components including a queue mock, also added one additional test to ensure that the Increment() feature actually incremented.Types of changes
Checklist
master
!master
branch (left side). Also, it would be best if you started your change off our latestmaster
.go mod tidy && go mod vendor
gofmt -s -w .
go vet ./...