Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"make check" should work #7

Open
jlevon opened this issue Nov 8, 2019 · 4 comments
Open

"make check" should work #7

jlevon opened this issue Nov 8, 2019 · 4 comments

Comments

@jlevon
Copy link
Contributor

jlevon commented Nov 8, 2019

Maybe dependent on #3 but "make check" in this repo should work.

@timfoster
Copy link
Contributor

(that was overzealous ticket referencing by github - ignore it, it's not related)

@timfoster
Copy link
Contributor

I ran prr through the joyent eslint plugins, which seemed to offer reasonable advice, and then through prettier/recommended, which imho made things look a bit worse, especially in the vasync pipelines:
https://gist.github.com/timfoster/b06c8f1ee75d494d72ace8b60759968b#file-prr-js-L898

Getting automatic code formatting is nice, but I don't think that's a price worth paying. I'll try a few of the other prettier configurations and see if those are less invasive, but suspect we'll just go with the joyent-eslint settings.

@timfoster
Copy link
Contributor

With a few // prettier-ignore comments on the vasync blocks, what prettier produces isn't that bad, though it would take some getting used to. I also haven't tried to "re-prettier" any of the contents of the ignored blocks, which means we do have some inconsistency, which isn't wonderful, I admit :-/

I'll push the eslint and prettier fixes as separate commits to the PR to see if there's consensus on what we should do. My gut feeling is to drop prettier and just use our eslint rules.

@timfoster
Copy link
Contributor

This is pull request #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants