-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"make check" should work #7
Comments
(that was overzealous ticket referencing by github - ignore it, it's not related) |
I ran prr through the joyent eslint plugins, which seemed to offer reasonable advice, and then through prettier/recommended, which imho made things look a bit worse, especially in the vasync pipelines: Getting automatic code formatting is nice, but I don't think that's a price worth paying. I'll try a few of the other prettier configurations and see if those are less invasive, but suspect we'll just go with the joyent-eslint settings. |
With a few I'll push the eslint and prettier fixes as separate commits to the PR to see if there's consensus on what we should do. My gut feeling is to drop prettier and just use our eslint rules. |
This is pull request #26 |
Maybe dependent on #3 but "make check" in this repo should work.
The text was updated successfully, but these errors were encountered: