Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaceMathTextWithKatax method is duplicated in highlight_list.ts and toc.js #918

Open
pano9000 opened this issue Jan 10, 2025 · 1 comment

Comments

@pano9000
Copy link
Contributor

Description

Hi,

not a bug, more a reminder so that we don't forget about this :-)
the replaceMathTextWithKatax function is currently duplicated in both highlight_list.ts and toc.js.

This screams like we should refactor it out to separate service in some way

TriliumNext Version

git

What operating system are you using?

Ubuntu

What is your setup?

Local (no sync)

Operating System Version

git

Error logs

No response

@eliandoran
Copy link
Contributor

I'm not actually sure if we should have KaTeX support in the highlights list, since it appears that I cannot highlight inline math elements, since they are actually inline blocks not inline elements.

See https://github.com/TriliumNext/Notes/pull/416/files#r1911975048.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants