Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more complex shapes #27

Open
DRSchlaubi opened this issue Sep 20, 2023 · 13 comments
Open

Add support for more complex shapes #27

DRSchlaubi opened this issue Sep 20, 2023 · 13 comments
Labels
specification Changes at specification

Comments

@DRSchlaubi
Copy link
Contributor

https://de.wikipedia.org/wiki/U-Bahn_M%C3%BCnchen#Linie_U7
https://de.wikipedia.org/wiki/U-Bahn_M%C3%BCnchen#Linie_U8

@jheubuch jheubuch added the specification Changes at specification label Sep 20, 2023
@jheubuch
Copy link
Collaborator

🥲

@jheubuch
Copy link
Collaborator

So.. if you have an idea, feel free to contribute :D but I guess, these Munich lines are like an edge-case. would be nice if those could be displayed, but I actually dont know how..

@DRSchlaubi
Copy link
Contributor Author

I enjoy suffering

@DRSchlaubi
Copy link
Contributor Author

Found a way

@jheubuch
Copy link
Collaborator

Yeah, I get what this is doing, but I guess we need to find a way for non-Webapplications to render this correctly and convenient without having parsing issues...

@DRSchlaubi
Copy link
Contributor Author

I don't feel like writing my own format for representing gradients

@tomjschwanke
Copy link
Contributor

tomjschwanke commented Oct 2, 2023

Leipzig uses circles for busses and squares for trams, eg:
image

The square can probably made with a rectangle and short text (just the line number), but I'm unsure about the circles

@tsia
Copy link

tsia commented Oct 15, 2023

How about SVG? Could represent all the weird and wonderful shapes and colors that some designers dream up

this idea was provided by @mrpelz

@mrpelz
Copy link

mrpelz commented Oct 15, 2023

SVG representations would basically treat these not as pictograms that are part of the displaying app’s design system but as icons that are ultimately defined by the operator (slightly different definitions for “pill” included).

But that’s fine, because their purpose is making what users encounter on screen resemble offline equivalents as closely as possible.

SVGs are also infinitely scalable, not limited to Web-based rendering and can be rendered without any additional info about predefined shapes, etc.

@oneiricbotcelot
Copy link
Contributor

I think another new shape which would represent a lot of bus lines is the regular hexagon. Examples can be found in Stuttgarts bus map.

@jheubuch
Copy link
Collaborator

I think hexagon already is on the specs (see readme down below) but I think nothing can render it atm (so please dont add it for the moment)

@oneiricbotcelot
Copy link
Contributor

A hexagon is on the specs indeed, but not a regular hexagon. I won't add corresponding lines until the shape is officially supported.

@vainamov
Copy link
Member

vainamov commented Dec 15, 2023

I think hexagon already is on the specs (see readme down below) but I think nothing can render it atm (so please dont add it for the moment)

In my opinion we shouldn't disapprove adding data to the set, just because it can't be rendered. Applications should ideally fallback to methods they support if they encounter unrecognized/non-implemented shapes.

Besides, there might be other use cases apart from rendering, that could benefit from this data nonetheless.

TheOneWithTheBraid added a commit to TheOneWithTheBraid/traewelldroid that referenced this issue Dec 24, 2024
- adds shared HexagonShape
- adds shared TrapezoidShape
- adds custom shapes to LineIcon

Related: Traewelling/line-colors#27

Signed-off-by: The one with the braid <[email protected]>
TheOneWithTheBraid added a commit to TheOneWithTheBraid/traewelldroid that referenced this issue Dec 24, 2024
- adds shared HexagonShape
- adds shared TrapezoidShape
- adds custom shapes to LineIcon

Related: Traewelling/line-colors#27

Signed-off-by: The one with the braid <[email protected]>
jheubuch pushed a commit to Traewelldroid/traewelldroid that referenced this issue Dec 27, 2024
- adds shared HexagonShape
- adds shared TrapezoidShape
- adds custom shapes to LineIcon

Related: Traewelling/line-colors#27

Signed-off-by: The one with the braid <[email protected]>
TheOneWithTheBraid added a commit to TheOneWithTheBraid/line-colors that referenced this issue Dec 29, 2024
- adds Liege S train
- adds circle shape to documentation
- adds circle shape example
- adds circle shape support to sample renderer

Related: Traewelling#27

Signed-off-by: The one with the braid <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
specification Changes at specification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants