Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with "Show Only The Skills That Need Attention" #161

Open
gjcdeluxe opened this issue Mar 20, 2021 · 4 comments
Open

Issue with "Show Only The Skills That Need Attention" #161

gjcdeluxe opened this issue Mar 20, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@gjcdeluxe
Copy link

Hi, I'm really liking this extension, and the "Show only the skills that need attention" option in particular is very handy, but I just discovered that it isn't behaving as I would expect. If this setting is enabled, then a skill will be displayed as long as it is partially completed, but as soon as you complete that skill to, say, level 1, it stops being shown, even though there are 4 more levels remaining that haven't been completed.

For example, here is how my tree looks when all skills are displayed:
Full Tree

If I enable "Show only the skills that need attention", I would expect Pres. Per., Pronouns, Formal You, and Imperative to be displayed, as they all have room for improvement, but instead, only Pres. Per. and Formal You are displayed:
Compressed Tree

Not sure whether that's a tricky one to fix or not, but thought I'd mention in case it's do-able. Thanks!

@ToranSharma
Copy link
Owner

ToranSharma commented Mar 21, 2021

The behaviour here is intended, but maybe does not fit with your duolingo approach.

In short Duo Strength is mainly built around the idea of bring more spaced repetition into the learning processes by adding back the individual skill strengths. A typical unfinished tree of a user following Duo Strengths suggestions would have a spread of skills at different crown levels, with all skills being practised from time to time, based on the spaced repetition systems of skill strength, and cracked skills for L5 skill. Lessons for unfinished skills are only done when there is nothing already learnt that needs practice (based on the spaced repetition systems).

Here is what the bottom of my en->es tree looks like with this crown level spread.
image

The "Show only the skills that need attention" option, uses the same skills are/would be shown in lists at the top of three tree. This is the skills that need strengthening, i.e. not 100% strength; cracked skills, and the skill suggestion (depending configured on the particular settings and tree state).

The behaviour you are seeing here is a result of the skills suggestion. The suggested skill feature works differently depending on the users tree level. If the tree is unfinished (tree level 0) then the skill suggestion works by suggesting the first L0 skill. This is how it is working in your screenshots, Formal You is the first L0 skill, so that is the skills that is suggested to be learnt next.

If the tree is finished (tree level >=L1) then the suggested skill is picked from all the skills at the tree level based on a customisable option in the settings. By default the selection method is set to random, but first and last are also options.

Also note that by default the skills suggestion is hidden if there are any skills that need strengthening or are cracked, with the intention there that the user should see to those first before doing any more lessons of a new skill.

All that said, I can add an option to change the behaviour of the skill suggestion to work in a different way, more akin to how you appear the be approaching the tree but getting each skill to L5 in turn. It shouldn't be too difficult a change to make, I'll look into it and try to include it in the next patch.

Toran

@gjcdeluxe
Copy link
Author

Thanks for the response, yes that makes sense - it seems I may well be using DL atypically then! I tend to revise any cracked skills first, and only chip away at a couple of new skills at a time, building them to level 5 before starting any more new ones (the narrower focus seems to make it easier for me to retain, compared to building multiple skills to level 1, then 2 and so on).

Many thanks for considering it though, I'll keep an eye out :)

@gjcdeluxe
Copy link
Author

gjcdeluxe commented Apr 19, 2021

Just as an update to that, now that all available skills in my tree are complete up to at least Level 0, I anticipated that DuoStrength would now un-hide the 5 skills for which I can do level 1 exercises, and maybe also the 1 skill for which I can do level 2 exercises. However, with "Show only the skills that need attention" enabled, all skills are hidden so my only option is to (very prematurely!) sit the Checkpoint 3 test. Here's a screenshot of my IT->EN tree, with and without that option enabled:
1
2

@ToranSharma ToranSharma added the enhancement New feature or request label Aug 12, 2021
@J053Fabi0
Copy link

I would also like to see the skills not on legendary level showing up with this option enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants