Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load (modelDescription of) FMU 3 throws a series of nonsense warnings about wrong types of not-included optional variable attributes #131

Closed
juguma opened this issue Nov 18, 2024 · 2 comments

Comments

@juguma
Copy link

juguma commented Nov 18, 2024

When you try to
myFMU = loadFMU(myFMU3CSpath)
of a CS3-FMU, which does not contain values for optional variable attributes (specifically observed for min, max, quantity), you get a warning for each missing attribute, more specifically, it is not a warning about the missing attribute, but about a non-supported type for the attribute, like:

┌ Warning: Unsupported typename `Boolean` for modelVariable attribute `max`.
└ @ FMIImport 

This is because in the respective function a condition like if haskey(node, "initial")... is missing.
This has to be included for all non-required attributes, which are all besides the name, and for clock types besides intervalVariability.

I guess you can easily modify existing FMU-modelDescriptions.xml to reproduce and fix the problem. :-)
And I guess the problem is not restricted to CS, but presumably to 3.

@ThummeTo
Copy link
Owner

true. can you please check out #132 ? Thanks!

@juguma
Copy link
Author

juguma commented Nov 19, 2024

Tested. Can confirm, it is solved in #132.

@juguma juguma closed this as completed Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants