From 2c8fb45e7bfba08a43cfbb588a00b2356db9f63d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Valentin=20Breu=C3=9F?= Date: Sun, 2 Feb 2025 15:03:56 +0100 Subject: [PATCH] refactor: fix build warnings in test projects (#1203) Fix build warnings in test projects. --- .../MockDirectoryInfoTests.cs | 2 ++ .../MockDirectoryTests.cs | 2 ++ .../MockFileArgumentPathTests.cs | 2 ++ .../MockFileInfoTests.cs | 3 +++ .../MockFileOpenTests.cs | 7 +++++++ .../MockFileTests.cs | 6 ++++++ 6 files changed, 22 insertions(+) diff --git a/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockDirectoryInfoTests.cs b/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockDirectoryInfoTests.cs index 7532d3558..87aece894 100644 --- a/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockDirectoryInfoTests.cs +++ b/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockDirectoryInfoTests.cs @@ -518,7 +518,9 @@ public void Directory_exists_after_creation_with_security() var directoryInfo = fileSystem.DirectoryInfo.New(XFS.Path(@"c:\abc")); // Act +#pragma warning disable CA1416 directoryInfo.Create(new DirectorySecurity()); +#pragma warning restore CA1416 // Assert Assert.That(directoryInfo.Exists, Is.True); diff --git a/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockDirectoryTests.cs b/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockDirectoryTests.cs index d36b434b4..4216e62e8 100644 --- a/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockDirectoryTests.cs +++ b/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockDirectoryTests.cs @@ -2085,7 +2085,9 @@ public void MockDirectory_GetAccessControl_ShouldThrowExceptionOnDirectoryNotFou var fileSystem = new MockFileSystem(); // Act +#pragma warning disable CA1416 Assert.Throws(() => fileSystem.Directory.GetAccessControl(XFS.Path(@"c:\foo"))); +#pragma warning restore CA1416 } [Test] diff --git a/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileArgumentPathTests.cs b/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileArgumentPathTests.cs index c41d9871f..097b9da85 100644 --- a/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileArgumentPathTests.cs +++ b/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileArgumentPathTests.cs @@ -51,8 +51,10 @@ private static IEnumerable> GetFileSystemActionsForArgumentNullExc yield return fs => fs.SetLastAccessTimeUtc((string)null, DateTime.Now); yield return fs => fs.SetLastWriteTime((string)null, DateTime.Now); yield return fs => fs.SetLastWriteTimeUtc((string)null, DateTime.Now); +#pragma warning disable CA1416 yield return fs => fs.Decrypt(null); yield return fs => fs.Encrypt(null); +#pragma warning restore CA1416 } [TestCaseSource(nameof(GetFileSystemActionsForArgumentNullException))] diff --git a/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileInfoTests.cs b/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileInfoTests.cs index 43b266e7c..ae7b2cd1c 100644 --- a/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileInfoTests.cs +++ b/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileInfoTests.cs @@ -499,7 +499,10 @@ public void MockFileInfo_OpenRead_ShouldReturnByteContentOfFile() byte[] result = new byte[2]; using (var stream = fileInfo.OpenRead()) { +#pragma warning disable CA2022 + // ReSharper disable once MustUseReturnValue stream.Read(result, 0, 2); +#pragma warning restore CA2022 } Assert.That(result, Is.EqualTo(new byte[] { 1, 2 })); diff --git a/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileOpenTests.cs b/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileOpenTests.cs index a5f8d3c2e..f88c03089 100644 --- a/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileOpenTests.cs +++ b/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileOpenTests.cs @@ -247,7 +247,9 @@ public void MockFile_Read_ShouldRetainCreationTimeAndUpdateLastAccessTime() var fi = fs.FileInfo.New(filepath); var stream = fi.OpenRead(); var buffer = new byte[16]; +#pragma warning disable CA2022 stream.Read(buffer, 0, buffer.Length); +#pragma warning restore CA2022 fi.Refresh(); // Assert Assert.That(fi.CreationTime, Is.EqualTo(creationTime)); @@ -270,7 +272,12 @@ public async Task MockFile_ReadAsync_ShouldRetainCreationTimeAndUpdateLastAccess var fi = fs.FileInfo.New(filepath); var stream = fi.OpenRead(); var buffer = new byte[16]; +#pragma warning disable CA1835 +#pragma warning disable CA2022 + // ReSharper disable once MustUseReturnValue await stream.ReadAsync(buffer, 0, buffer.Length); +#pragma warning restore CA2022 +#pragma warning restore CA1835 fi.Refresh(); // Assert Assert.That(fi.CreationTime, Is.EqualTo(creationTime)); diff --git a/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileTests.cs b/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileTests.cs index beb413068..53b18ffdf 100644 --- a/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileTests.cs +++ b/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileTests.cs @@ -605,7 +605,9 @@ public void MockFile_Encrypt_ShouldSetEncryptedAttribute() }); // Act +#pragma warning disable CA1416 fileSystem.File.Encrypt(filePath); +#pragma warning restore CA1416 var attributes = fileSystem.File.GetAttributes(filePath); // Assert @@ -623,10 +625,14 @@ public void MockFile_Decrypt_ShouldRemoveEncryptedAttribute() { {filePath, fileData } }); +#pragma warning disable CA1416 fileSystem.File.Encrypt(filePath); +#pragma warning restore CA1416 // Act +#pragma warning disable CA1416 fileSystem.File.Decrypt(filePath); +#pragma warning restore CA1416 var attributes = fileSystem.File.GetAttributes(filePath); // Assert