Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add display scale factor to default parameters #210

Closed
daprice opened this issue Nov 30, 2024 · 2 comments · Fixed by #213
Closed

Feature request: add display scale factor to default parameters #210

daprice opened this issue Nov 30, 2024 · 2 comments · Fixed by #213

Comments

@daprice
Copy link

daprice commented Nov 30, 2024

Since TelemetryDeck.Device.screenResolutionWidth and screenResolutionHeight are in points, not pixels, it always reports 1080p on tvOS no matter what, even if the TV is 4k. Adding the display scale (e.g. UIScreen.main.scale) would allow differentiating between the two resolutions without having to change how the existing width and height parameters are measured.

Also for macOS, it might be helpful to be able to tell what percentage of users are on retina displays.

@Jeehut
Copy link
Contributor

Jeehut commented Dec 1, 2024

@daprice Thank you for the great suggestion.

This has been implemented as of #213 and should be merged & releases soon!

@Jeehut
Copy link
Contributor

Jeehut commented Dec 2, 2024

@daprice I'm happy to inform you that the feature is now part of the new SDK release 2.6.0.

Please give it a try and let me know if this works for you! The field is called TelemetryDeck.Device.screenScaleFactor. Thank you again for requesting this. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants