Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Review ValueAsString return logic #106

Open
jordipuigbou opened this issue Jul 14, 2022 · 0 comments
Open

[Feature]: Review ValueAsString return logic #106

jordipuigbou opened this issue Jul 14, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@jordipuigbou
Copy link
Contributor

jordipuigbou commented Jul 14, 2022

What is your suggestion?

Review ValueAsString return logic when required value is not found. Different values are returned when not found.
Example:

	URL := golium.ValueAsString(ctx, "[CONF:url]")
	if URL == "<nil>" {
		URL = golium.ValueAsString(ctx, "[CTXT:url]")
	}
	if URL == "%nil%" {
		return "", fmt.Errorf("url shall be initialized in Configuration or Context")
	}
@jordipuigbou jordipuigbou added the enhancement New feature or request label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant