You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Evaluate the possibility to add to the system two new set of tokens for states:
brandHover / brandPressed: using brand with 5% alpha / 15% alpha
errorHover / errorPressed: using error with 5% alpha / 15% alpha
Example of the PrimaryButton inverse states with the proposal
Context
Since we introduced the counter and the addition of the icon button definition. States for icons using brand or error colors can be a good addition to the current state tokens.
For example the counter is currently using brandLow as hover state and lacks of pressed.
The current states for buttonSecondary and buttonLink follows the same principle:
This states can be also reused in other applications of the buttonPrimary (inverse), where the current color is affecting the legibility of the label.
We can apply the same principle to buttonLink danger in inverse, that actually is reusing the formula of the counter adding a pressed state.
Impact
Standarize states for all uses of brand color in buttons + the nuew definition of iconButton and toggleIconButton
Discussion Questions
Are other cases where this tokens can be applied
Should backgroundContainerBrandHover/Pressed be renamed to backgroundContainerInverseHover and use the former for brandHover?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Goal
Evaluate the possibility to add to the system two new set of tokens for states:
Example of the PrimaryButton inverse states with the proposal
Context
Since we introduced the counter and the addition of the icon button definition. States for icons using brand or error colors can be a good addition to the current state tokens.
For example the counter is currently using
brandLow
as hover state and lacks of pressed.The current states for buttonSecondary and buttonLink follows the same principle:
This states can be also reused in other applications of the buttonPrimary (inverse), where the current color is affecting the legibility of the label.
We can apply the same principle to buttonLink danger in inverse, that actually is reusing the formula of the counter adding a pressed state.
Impact
Standarize states for all uses of brand color in buttons + the nuew definition of iconButton and toggleIconButton
Discussion Questions
Additional considerations
No response
Do you have a visual proposal?
No response
Beta Was this translation helpful? Give feedback.
All reactions