Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Overhaul entire system to use string drawing instead of labels #41

Open
Sudospective opened this issue Feb 20, 2021 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Sudospective
Copy link
Member

I'd like to eventually do a complete rework of the internal print function to directly draw strings rather than create labels with one character each. This would greatly reduce overhead and allow for easier customization. This may also fix the currently open issue with positional effects as well as allow the editor view to finally be functional.

@Sudospective Sudospective added enhancement New feature or request help wanted Extra attention is needed labels Feb 20, 2021
@I-Have-No-Idea-What-IAmDoing
Copy link
Contributor

it might be worth using RichTextLabels instead as an alternative to creating our own system though i haven't really done a lot research on it yet

https://docs.godotengine.org/en/stable/tutorials/gui/bbcode_in_richtextlabel.html
https://docs.godotengine.org/en/stable/classes/class_charfxtransform.html

@Sudospective
Copy link
Member Author

Sudospective commented Feb 24, 2021

While that is a nice idea, the point is to comoletely cut out the need for creating any new objects for text creation. Using one RichTextLabel instead of many Labels is good, but using draw_string() or draw_char() would bring the object-to-character count to 0, and that's my real goal here.

@I-Have-No-Idea-What-IAmDoing
Copy link
Contributor

Hey are you working on this?

If not i was thinking of working on this, but i wanted to make sure that i am not redoing any work.

@Sudospective
Copy link
Member Author

I haven't actually started on this, to be honest. I've been wrapped up in other projects since last year (one of them being Project OutFox!) and haven't had time to work on this engine since. If you'd like to do this, that would be tremendously appreciated!

@I-Have-No-Idea-What-IAmDoing
Copy link
Contributor

TextTest
0 labels or nodes just pure draw_char that can be ported to godot 4

I try to open a PR soon, though it is very WIP right now :)

Ps: I found this weird bug that allow for an interesting fall down effect for text which could be useful for some games

@Sudospective
Copy link
Member Author

YOU ARE A LIFESAVER IVE BEEN SWAMPED WITH LIFE FOR THE PAST EON OR SO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants