Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 에셋 추가 및 수정사항 반영 - 민우 #88

Merged
merged 8 commits into from
Jan 9, 2024

Conversation

Doreminwoo
Copy link
Member

Related issue 🛠

Work Description ✏️

  • 라이팅 수정
  • 에셋 이미지 추가
  • 기기대응 버그 코드 변경
  • 디자인 요청사항 변경

Screenshot 📸

Recording_2024-01-10-05-02-22.mp4

Uncompleted Tasks 😅

N/A

To Reviewers 📢

N/A

@Doreminwoo Doreminwoo requested a review from a team as a code owner January 9, 2024 20:10
@Doreminwoo Doreminwoo self-assigned this Jan 9, 2024
@Doreminwoo Doreminwoo linked an issue Jan 9, 2024 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다음에 마저 볼게요 졸림 이슈임 진짜

@@ -57,5 +59,6 @@ class JoinGroupCodeActivity :

companion object {
const val GROUP_NAME = "groupName"
const val SNACKBAR_MESSAGE = "초대 코드를 다시 확인해주세요!"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스트링 추출로 해줘여

@Doreminwoo Doreminwoo merged commit 047a5d0 into develop Jan 9, 2024
1 check passed
@Doreminwoo Doreminwoo deleted the feat-asset-wirte-onboarding branch January 9, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[feat] 에셋 추가 및 수정사항 반영 - 민우
2 participants