Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Make gifs animate in app #338

Closed
3 tasks done
Thecreatre opened this issue Aug 3, 2024 · 7 comments
Closed
3 tasks done

[Feature Request]: Make gifs animate in app #338

Thecreatre opened this issue Aug 3, 2024 · 7 comments
Labels
Type: Enhancement New feature or request Type: UI/UX User interface and/or user experience

Comments

@Thecreatre
Copy link

Checklist

  • I am using an up-to-date version.
  • I have read the documentation.
  • I have searched existing issues.

Description

its as simple as the title make gifs work in app

(also Apng too but it might work allready and i wouldn't know cause i don't have any apps other than a decomp* thing for Apngs)

*(splits off the other images hidden in the file)

Solution

make gifs (and maybe Apngs if they didn't work already) work in tag studio

(also maybe get it to work for those cached thumbnails upcoming feature probably things, but its not as required as just making it work in the tiny viewer thing)

Alternatives

No response

@Thecreatre Thecreatre added the Type: Enhancement New feature or request label Aug 3, 2024
@CyanVoxel CyanVoxel added the Type: UI/UX User interface and/or user experience label Aug 3, 2024
@CyanVoxel CyanVoxel added this to the Alpha 9.4 milestone Aug 3, 2024
@CyanVoxel
Copy link
Member

GIF previews are currently operational on the thumbnails branch, which will be merged into the upcoming 9.4 release

@Thecreatre
Copy link
Author

i see, (didnt know that even existed)

@Thecreatre
Copy link
Author

I'll probably just keep using the main branch tbh, its not too annoying for me, at least if i keep open a instance of photos so that #339 doesn't lock up photos again

@CyanVoxel
Copy link
Member

I'll probably just keep using the main branch tbh, its not too annoying for me, at least if i keep open a instance of photos so that #339 doesn't lock up photos again

I'd recommend the same, if anything keep an eye out for when I eventually make a PR and it gets merged into the Alpha-9.4 branch, although by then I may make a pre-release for 9.4 based on the state of that branch.

Also to address APNG playback, I've done some initial testing to see if it would be immediately supported by my GIF playback implementation but it looks like it isn't natively supported by Qt. That being said I may be able to just convert the APNG file to a GIF on the fly and plug it into the playback system. Animated WEBPs are also easy to get working, although I'd rather develop a way to distinguish still from animated WEBP files in the preview pane before adding that in due to some UI quirks.

@Thecreatre
Copy link
Author

ah i see

@BPplays
Copy link
Contributor

BPplays commented Aug 21, 2024

@CyanVoxel i feel like converting APNG to WEBP instead of GIF is probably a better idea
i made a PR for it #357

@CyanVoxel
Copy link
Member

GIF playback added in #390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request Type: UI/UX User interface and/or user experience
Projects
None yet
Development

No branches or pull requests

3 participants