Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping few seconds with buttons or arrow keys not possible anymore #1471

Closed
michal-gora opened this issue Jan 12, 2025 · 7 comments · Fixed by #1477
Closed

Skipping few seconds with buttons or arrow keys not possible anymore #1471

michal-gora opened this issue Jan 12, 2025 · 7 comments · Fixed by #1477
Labels
bug Something isn't working

Comments

@michal-gora
Copy link

michal-gora commented Jan 12, 2025

Describe the bug
The bug is that it is not possible to skip a few seconds forwards or backwards anymore.

To Reproduce
Steps to reproduce the behavior:

  1. Go to live.rbg.tum.de
  2. Click on any recorded lecture
  3. Find the skip forward/backward button or use arrow to skip a few seconds forwards or backwards
  4. Problem: No buttons and arrows dont work

Expected behavior
There should be a way to skip forward/backward in time using either buttons or the arrow keys.

Screenshots
image
(see missing skip buttons)

Desktop (please complete the following information):

  • OS: Linux Ubuntu 24.04
  • Browser: firefox 134 64bit
  • Version: ?

Additional context
It has worked yesterday (11.01.2025)

@d-rothen
Copy link

Some event handler probably not properly defined
image

@michal-gora
Copy link
Author

I also noticed that the automatic skipping button to skip empty lecture segments is gone too. Something was broken with a recent update

@karjo24 karjo24 added the bug Something isn't working label Jan 13, 2025
@joschahenningsen
Copy link
Member

Pretty sure this is the commit at fault: 08b9166

@KemalKrKX
Copy link
Contributor

There is a temporary workaround you can use for skipping 5 seconds. If you press TAB-key multiple times (5 for me) until the video progress bar is highlighted the arrow keys work. However you need to do this again every time after clicking anywhere, else it stops working. @michal-gora

@michal-gora
Copy link
Author

@KemalKrKX Thanks. I also found another workaround using the Picture-in-Picture mode (in firefox) which can be viewed in fullscreen too and there skipping 5s in each direction is possible.

@laxerhd
Copy link

laxerhd commented Jan 14, 2025

The mini preview when hovering over the video progress bar is also not working.
Is this the same bug affecting this as well?

@joschahenningsen
Copy link
Member

Pretty sure, all of this can be traced back to updating the player dependency, so yes. Should be the same bug. I want to roll back the problematic release tonight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants